st: Do not use markup in button labels

It sounds strange that buttons would admit Pango markup
in their label text. It sounds better to default to plain
text, and let users wanting markup to access the child
directly.

This also makes the first label being set consistent
with later text being assigned wrt markup usage, since
the non-markup ClutterText API is used if the child is
already present and of the expected type.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3149>

diff --git a/src/st/st-button.c b/src/st/st-button.c
index a958c1491517b154002660f0c282fcbf526a15ae..42745f361ff46d78ef6e15d26c7cceb221511cc8 100644 (file)
--- a/src/st/st-button.c
+++ b/src/st/st-button.c
@@ -682,7 +682,6 @@ st_button_set_label (StButton    *button,
                             "text", priv->text,
                             "line-alignment", PANGO_ALIGN_CENTER,
                             "ellipsize", PANGO_ELLIPSIZE_END,
-                            "use-markup", TRUE,
                             "x-align", CLUTTER_ACTOR_ALIGN_CENTER,
                             "y-align", CLUTTER_ACTOR_ALIGN_CENTER,
                             NULL);